fix(quickemu): read "Vendor ID" for CPU vendor detection#1846
Merged
flexiondotorg merged 2 commits intomasterfrom Jan 26, 2026
Merged
fix(quickemu): read "Vendor ID" for CPU vendor detection#1846flexiondotorg merged 2 commits intomasterfrom
flexiondotorg merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- There is a concrete macOS regression risk:
get_cpu_infoexits when it sees the new^Vendor IDlookup, which is only valid for Linux, so macOS hosts may fail to detect CPU info. - Given the 7/10 severity and high confidence, this adds some user-facing risk despite being a small change.
- Pay close attention to
quickemu- keep the Linux-only Vendor ID pattern off macOS to avoid unknown key exits.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="quickemu">
<violation number="1" location="quickemu:480">
P1: The new '^Vendor ID' lookup breaks macOS because get_cpu_info only recognizes "Vendor" for Darwin and exits on unknown keys. Use the Linux-only pattern for Linux hosts and keep "Vendor" on macOS.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Change HOST_CPU_VENDOR lookup to use '^Vendor ID' when parsing /proc/cpuinfo - Ensures correct CPU vendor detection on systems that label the field as 'Vendor ID' instead of 'Vendor' Fixes #1845 Signed-off-by: Martin Wimpress <martin@wimpress.org>
b53dc11 to
89e8880
Compare
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1845
Type of change
Checklist: