Skip to content

fix(quickemu): read "Vendor ID" for CPU vendor detection#1846

Merged
flexiondotorg merged 2 commits intomasterfrom
cpu-vendor-fix
Jan 26, 2026
Merged

fix(quickemu): read "Vendor ID" for CPU vendor detection#1846
flexiondotorg merged 2 commits intomasterfrom
cpu-vendor-fix

Conversation

@flexiondotorg
Copy link
Member

  • Change HOST_CPU_VENDOR lookup to use '^Vendor ID' when parsing /proc/cpuinfo
  • Ensures correct CPU vendor detection on systems that label the field as 'Vendor ID' instead of 'Vendor'

Fixes #1845

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Confidence score: 3/5

  • There is a concrete macOS regression risk: get_cpu_info exits when it sees the new ^Vendor ID lookup, which is only valid for Linux, so macOS hosts may fail to detect CPU info.
  • Given the 7/10 severity and high confidence, this adds some user-facing risk despite being a small change.
  • Pay close attention to quickemu - keep the Linux-only Vendor ID pattern off macOS to avoid unknown key exits.
Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="quickemu">

<violation number="1" location="quickemu:480">
P1: The new '^Vendor ID' lookup breaks macOS because get_cpu_info only recognizes "Vendor" for Darwin and exits on unknown keys. Use the Linux-only pattern for Linux hosts and keep "Vendor" on macOS.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

- Change HOST_CPU_VENDOR lookup to use '^Vendor ID' when parsing
/proc/cpuinfo
- Ensures correct CPU vendor detection on systems that label the field
as 'Vendor ID' instead of 'Vendor'

Fixes #1845

Signed-off-by: Martin Wimpress <martin@wimpress.org>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@flexiondotorg flexiondotorg merged commit 3c16de4 into master Jan 26, 2026
5 checks passed
@flexiondotorg flexiondotorg deleted the cpu-vendor-fix branch January 26, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Unknown CPU warning for GenuineIntel Google

1 participant