Skip to content

fix(quickemu): simplify display device selection and remove -vga none #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flexiondotorg merged 1 commit into from
Jan 27, 2026
Merged

fix(quickemu): simplify display device selection and remove -vga none #1848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions quickemu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,16 +1297,12 @@ function configure_display() {
esac
fi;;
macos)
# qxl-vga and VGA supports seamless mouse and sane resolutions if only
# one scanout is used. '-vga none' is added to the QEMU command line
# to avoid having two scanouts.
# VGA supports seamless mouse and sane resolutions for macOS guests
DISPLAY_DEVICE="VGA";;
windows|windows-server)
# virtio-gpu "works" with gtk but is limited to 1024x1024 and exhibits other issues
# https://kevinlocke.name/bits/2021/12/10/windows-11-guest-virtio-libvirt/#video
case ${display} in
gtk|none|spice) DISPLAY_DEVICE="qxl-vga";;
cocoa|sdl|spice-app) DISPLAY_DEVICE="virtio-vga";;
none|spice) DISPLAY_DEVICE="qxl-vga";;
cocoa|gtk|sdl|spice-app) DISPLAY_DEVICE="virtio-vga";;
esac;;
*) DISPLAY_DEVICE="qxl-vga";;
esac
Expand Down Expand Up @@ -1386,15 +1382,8 @@ function configure_display() {
VIDEO="${VIDEO},max_outputs=${max_outputs}"
fi

# Run QEMU with '-vga none' to avoid having two scanouts, one for VGA and
# another for virtio-vga-gl. This works around a GTK assertion failure and
# allows seamless mouse in macOS when using the qxl-vga device.
# https://www.collabora.com/news-and-blog/blog/2021/11/26/venus-on-qemu-enabling-new-virtual-vulkan-driver/
# https://github.com/quickemu-project/quickemu/issues/222
VGA="-vga none"

# Add fullscreen options
VIDEO="${VGA} ${VIDEO} ${FULLSCREEN}"
VIDEO="${VIDEO} ${FULLSCREEN}"
}

function configure_audio() {
Expand Down Expand Up @@ -1605,7 +1594,6 @@ function vm_boot() {
SMM="${SMM:-off}"
local TEMP_PORT=""
USB_HOST_PASSTHROUGH_CONTROLLER="qemu-xhci"
VGA=""
VIDEO=""

KERNEL_NAME="$(uname -s)"
Expand Down
Loading