docs: align manual pages with release 4.9.8#1858
docs: align manual pages with release 4.9.8#1858flexiondotorg merged 1 commit intoquickemu-project:masterfrom
Conversation
There was a problem hiding this comment.
2 issues found across 8 files
Confidence score: 5/5
- Only minor documentation typos in
docs/quickemu.1.mdanddocs/quickget.1("recover image" vs "recovery image"), no functional impact - Score 5 because issues are low-severity, non-user-impacting documentation wording fixes
- No files require special attention.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickemu.1.md">
<violation number="1" location="docs/quickemu.1.md:569">
P3: Typo in documentation: use “recovery image” instead of “recover image.”</violation>
</file>
<file name="docs/quickget.1">
<violation number="1" location="docs/quickget.1:393">
P3: Typo in the new macOS VPN note: "recover image" should be "recovery image" for correctness.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
cd77776 to
a2d06e4
Compare
|
@cubic-dev-ai typo addressed in regeneration from source - please re-review |
@philclifford I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 5/5
- This PR looks safe to merge; the only noted issue is a low-severity documentation inconsistency.
- The manpage in
docs/quickemu.1lists two different defaults for--display(sdl vs gtk), which could confuse users but won’t affect runtime behavior. - Pay close attention to
docs/quickemu.1- reconcile the documented default display backend.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickemu.1">
<violation number="1" location="docs/quickemu.1:1159">
P3: The manpage now lists two conflicting defaults for `--display` (sdl vs gtk). Please reconcile both sections so the default backend is documented consistently.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
a2d06e4 to
ffc88fa
Compare
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 5/5
- Only a minor documentation formatting issue in
docs/quickemu.1(missing space before a colon) that affects manpage alignment, not functionality. - Pay close attention to
docs/quickemu.1- keep option list formatting aligned.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickemu.1">
<violation number="1" location="docs/quickemu.1:585">
P3: The new `--check-all-arch` entry is missing the space before the colon that the rest of the option list uses, which causes misaligned formatting in the rendered manpage. Add the space to keep the column alignment consistent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
as per quickemu-project/quickemu#1858 (comment) Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
as per quickemu-project#1858 (comment) with adjustment of flag alignment in _ _ _ __ _ _ _(_) ___| | ____ _ ___| |_ / _` | | | | |/ __| |/ / _` |/ _ \ __| | (_| | |_| | | (__| < (_| | __/ |_ \__, |\__,_|_|\___|_|\_\__, |\___|\__| |_| |___/ v4.9.9, using curl 7.81.0 -------------------------------------------------------------------------------- Project - https://github.com/quickemu-project/quickemu Discord - https://wimpysworld.io/discord -------------------------------------------------------------------------------- Usage: quickget <os> <release> [edition] quickget ubuntu 22.04 Advanced usage: quickget <arg> [path] <os> [release] [edition] quickget --download ubuntu 22.04 Arguments: --arch <arch> : Set architecture (arm64, aarch64, amd64, x86_64) --download <os> <release> [edition] : Download image; no VM configuration --create-config <os> [path/url] [flags] : Create VM config for an OS image --open-homepage <os> : Open homepage for the OS --show [os] : Show OS information --version : Show version --help : Show this help message ------------------------------------ Flags ------------------------------------- --create-config: --disable-unattended : Force quickget not to set up an unattended installation -------------------------- For testing & development --------------------------- --url [os] [release] [edition] : Show image URL(s) --check [os] [release] [edition] : Check image URL(s) --check-all-arch [os] [release] [edition]: Check downloads for all architectures (amd64 and arm64) --list : List all supported systems --list-csv : List everything in csv format --list-json : List everything in json format -------------------------------------------------------------------------------- Supported Operating Systems: alma alpine android antix archcraft archlinux artixlinux azurelinux batocera bazzite biglinux blendos bodhi bunsenlabs cachyos centos-stream chimeralinux crunchbang++ debian deepin devuan dragonflybsd easyos edubuntu elementary endeavouros endless fedora freebsd freedos garuda gentoo ghostbsd gnomeos guix haiku kali kdeneon kolibrios kubuntu linuxlite linuxmint lmde lubuntu maboxlinux macos mageia manjaro mxlinux netboot netbsd nitrux nixos nwg-shell openbsd openindiana opensuse oraclelinux parrotsec pclinuxos peppermint popos porteus primtux proxmox-ve pureos reactos rebornos rockylinux siduction slackware slax slint slitaz solus sparkylinux spirallinux tails tinycore trisquel tuxedo-os ubuntu ubuntu-budgie ubuntu-mate ubuntu-server ubuntu-unity ubuntucinnamon ubuntukylin ubuntustudio vanillaos void windows windows-server xubuntu zorin and regenerated docs Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
as per quickemu-project/quickemu#1858 (comment) Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
|
@cubic-dev-ai Another review, please. |
@flexiondotorg I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 4/5
- Safe to merge overall; the only issue is a documentation omission rather than runtime behavior
docs/quickget.1no longer mentions the supported--disable-unattendedflag, which could confuse users looking to disable unattended installs- Pay close attention to
docs/quickget.1- restore the missing--disable-unattendedoption in the advanced options list.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickget.1">
<violation number="1" location="docs/quickget.1:133">
P2: The advanced options list no longer documents the `--disable-unattended` flag even though quickget still supports it, so the manpage now omits how to disable unattended installs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 5/5
- Only a minor documentation formatting tweak in
docs/quickemu.1, so risk to functionality is negligible - This PR looks safe to merge; the noted issue is low severity and purely cosmetic
- Pay close attention to
docs/quickemu.1- keep the--check-all-archentry colon spacing aligned with the rest of the list.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickemu.1">
<violation number="1" location="docs/quickemu.1:585">
P3: Align the spacing before the colon in the `--check-all-arch` entry so the quickget options list keeps consistent column alignment.
(Based on your team's feedback about consistent quickget help_message colon alignment.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Failing CI checks when done locally are reduced to and even then FreeDOS seems to pass if you are patient enough (maybe ibiblio.org is struggling) opensuse 16.1 artifacts seem to have been removed upstream |
There was a problem hiding this comment.
1 issue found across 5 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/quickemu.1.md">
<violation number="1" location="docs/quickemu.1.md:409">
P3: The manpage block is out of sync with `quickget`’s help output: the testing-only options (`--url`, `--check`, `--list*`) are listed in the main options block instead of under the “For testing & development” section. Regenerate the manpage or adjust the block so option grouping matches the actual help message.
(Based on your team's feedback about keeping manpage option formatting aligned and regenerating the manpages.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
42c4093 to
335ed50
Compare
|
Squashed generated documentation changes. |
@philclifford I have started the AI code review. It will take a few minutes to complete. |
335ed50 to
50f24a3
Compare
chore: align doc submodule commit docs(quickget): adapt whitespace in help_message() needed in manual page regeneration to retain filtering of needed lines currently omits the new flag for --disable-unattended Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
50f24a3 to
9507ba7
Compare
Description
Align documentation with Release 4.9.8
Type of change
Checklist: