Merged
Conversation
- Use a function to verify the existence of required variables The previous approach was always checking the existence of variables, even for targets that did not require them e.g. `make fmt` would fail if any docker/registry variable was not defined. Now only targets that actually use those variable check for their definition state. - Install YTT locally We use some YTT where doing something very simple e.g. updating a container image, is terribly complicated in kustomize. Observe and compare deploy-dev vs deploy-local - Use "local" build and deploy targets "Local" targets that build containers locally and reference them in manifests, without pushing them. This is particularly useful in local environments, e.g. Docker Desktop, Rancher Desktop, where docker context is the same for Kuberentes and Image Building.
MirahImage
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
The previous approach was always checking the existence of variables,
even for targets that did not require them e.g.
make fmtwould fail ifany docker/registry variable was not defined. Now only targets that
actually use those variable check for their definition state.
We use some YTT where doing something very simple e.g. updating a
container image, is terribly complicated in kustomize. Observe and
compare deploy-dev vs deploy-local
"Local" targets that build containers locally and reference them in
manifests, without pushing them. This is particularly useful in local
environments, e.g. Docker Desktop, Rancher Desktop, where docker
context is the same for Kuberentes and Image Building.