Skip to content

Conversation

@nateberkopec
Copy link
Contributor

This was part of the "lessons learned" from Bannerbear's DDoS attack: https://www.bannerbear.com/blog/how-to-survive-a-ddos-attack/

I think perhaps many people are blindly copying this line from the readme:

Rack::Attack.cache.store = ActiveSupport::Cache::MemoryStore.new # defaults to Rails.cache

There really isn't a reason to have this line in the Readme, because the default is OK. We should include an example of what most apps will probably want to do, which is to set this to a Redis or Memcached store, not a MemoryStore, which is probably appropriate only for local-only toy apps.

Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README changes make sense to me.

Thank you @nateberkopec!

@grzuy grzuy merged commit c8e574a into rack:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants