Surface Resume at Finder root, group everything else under Assets - #6
Open
radroid wants to merge 1 commit into
Open
Surface Resume at Finder root, group everything else under Assets#6radroid wants to merge 1 commit into
radroid wants to merge 1 commit into
Conversation
Visitors opening Finder now see the Resume PDF as the first item (top-left of the icon grid) alongside a single Assets folder containing the existing Applications and Fonts sub-folders plus the loose root-level files. Generalizes the Finder's navigation to walk pathStack arbitrarily deep so Assets can hold nested folders. https://claude.ai/code/session_01M9ddciS17Eq3bLLyAsv7sB
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
raj-portfolio | f0e07f5 | Commit Preview URL Branch Preview URL |
Apr 29 2026, 04:20 PM |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganize the Finder app's root listing so visitors immediately see the Resume PDF, with everything else tucked behind a single
Assetsfolder.Before: root showed 3 folders (
Applications,Documents,Fonts) intermixed with 7 loose files (Apple Logo,Mac Icon,Curly OS Logo,Corner Logo,Avatar,World Map,Startup Sound) — 10 items competing for attention. The Resume was buried one level deep insideDocuments/.After: root has exactly 2 items —
Resume(PDF, top-left of the icon grid) andAssets/. The oldDocuments/wrapper folder is dropped;Applications/,Fonts/, and the previously-loose root files all move insideAssets/.What changed
app/components/apps/finder.tsx:FILE_TREErestructured. Resume is now a root-level file at index 0; everything else lives under a newAssetsfolder. No new sub-groupings invented insideAssets— the existingApplicationsandFontsfolders are preserved verbatim.topFolder = FILE_TREE.find(... pathStack[0])only supported one level of folder depth. Replaced with a tree walk that consumes each id inpathStack, soAssets → Applications(3 levels deep) works. Falls back gracefully ifpathStackever contains an unknown id (truncates rather than crashing).handleOpenandhandleBackare unchanged — their stack semantics already match.No other files touched. No new dependencies. No new components. ~38 insertions / 31 deletions in a single file.
Out of scope
DESKTOP-PLAN.mdexplicitly noted "ship with just the resume for now"). Skipped per the requesting user's preference.Resume→CV. Cosmetic only; the existing label matches the source filename (Raj_Dholakia_Resume_FullStack.pdf).Assets(e.g., aLogos/folder for the four logo SVGs). Kept the change literal to the user's ask of "all the other files and folders" going under Assets.Test plan
After
bun run dev, in a browser:Resume(top-left) andAssets. Status bar reads2 items, 72K in disk, 400K available. Breadcrumb isMacintosh HD. Back button is disabled.<iframe>. Right-click → Download saves the file.Macintosh HD > Assets, Back enables, grid shows 9 items (Applications, Fonts, Apple Logo, Mac Icon, Curly OS Logo, Corner Logo, Avatar, World Map, Startup Sound).Macintosh HD > Assets > Applications, 9 items (the app SVGs). Confirms 3-level navigation works.bunx tsc --noEmitreports no new errors.Stacking
Targets
refactor/reduce-loc(open PR #4) since that's where the Finder lives. If/when #4 merges tomain, this PR's base auto-retargets.https://claude.ai/code/session_01M9ddciS17Eq3bLLyAsv7sB
Generated by Claude Code