fix(server): treat slow az --version as present, not missing (#4)

[radroid]

Summary

Fixes #4. On Windows the Azure DevOps connector reported "not available" with the install az hint even when the Azure CLI was installed, on PATH, and authenticated.

Root cause: the source-control discovery probe hard-coded a 5s timeout on az --version and its catch-all mapped every failure — including a VcsProcessTimeoutError — to status: "missing", which rendered the install hint and short-circuited the fast (~1s) az account show auth check. az --version on Windows routinely takes 6–8s (Python startup + the Azure CLI "updates available" check), so a present-but-slow CLI was misclassified as missing.

Changes (apps/server/src/sourceControl/SourceControlProviderDiscovery.ts)

1. Raise the probe budget: replace the three hard-coded timeoutMs: 5_000 values with a named CLI_PROBE_TIMEOUT_MS = 15_000 (well above the observed 6–8s tail; still below the module's 30s default).
2. Distinguish timeout from missing: probeCli's error handler now branches on the cause tag — only VcsProcessSpawnError (ENOENT / genuine spawn failure) → status: "missing" + install hint. A timeout (or any other runtime failure) → status: "available", so probeSourceControlProvider still runs the fast az account show auth probe instead of short-circuiting.

No contract change — SourceControlDiscoveryStatus stays "available" | "missing"; a slow-but-present CLI resolves through the existing "available" + auth path, which the desktop Settings UI already renders as "Authenticated as …".

Tests (new SourceControlProviderDiscovery.test.ts)

TDD — written to fail first, then made green. Drives the exported probeSourceControlProvider with a capturing mock VcsProcess:

• --version times out + auth succeeds → available + authenticated, and the az account show probe actually runs. (red before fix)
• --version spawn error (ENOENT) → missing + unknown, auth probe not attempted. (regression guard)
• Happy path → --version probe timeoutMs >= 15000, version parsed, available + authenticated. (red before fix)
• --version times out + account show exits non-zero → available + unauthenticated.

Verification

• vp test run src/sourceControl/ → 13 files / 94 tests pass
• tsgo --noEmit → clean (exit 0)
• vp fmt --check + lint on changed files → clean

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e42ab158-a25d-42df-a571-d49fc8ed4983

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3x/fix-azure-devops-probe-timeout

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}