Skip to content

Fix v0.5.4 desktop size gate - #5

Merged
dekanbro merged 1 commit into
mainfrom
fix/v0.5.4-desktop-size
Aug 4, 2026
Merged

Fix v0.5.4 desktop size gate#5
dekanbro merged 1 commit into
mainfrom
fix/v0.5.4-desktop-size

Conversation

@dekanbro

@dekanbro dekanbro commented Aug 4, 2026

Copy link
Copy Markdown

Extract the existing initial-window helpers from lib.rs into a focused module. This is behavior-preserving and brings lib.rs from 1,010 to 945 lines so the desktop file-size ratchet passes after the v0.5.4 merge.

Validation:

  • cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --check
  • pnpm --dir desktop check
  • pnpm --dir desktop typecheck
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Improved macOS app startup so the initial window appears smoothly after rendering is ready.
    • Prevented window flickering and visual artifacts during launch.
    • Added geometry stabilization to ensure the window opens at the correct size and position.
    • Improved startup resilience by handling window errors without crashing.

Signed-off-by: Dekan Brown <dekanbro@gmail.com>
@dekanbro
dekanbro merged commit fd5f85b into main Aug 4, 2026
@dekanbro
dekanbro deleted the fix/v0.5.4-desktop-size branch August 4, 2026 13:14
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 95a39c39-a065-4dc7-bd16-72d337e1acd1

📥 Commits

Reviewing files that changed from the base of the PR and between 52edde4 and 9704371.

📒 Files selected for processing (2)
  • desktop/src-tauri/src/initial_window.rs
  • desktop/src-tauri/src/lib.rs

📝 Walkthrough

Walkthrough

The change moves initial-window behavior into a dedicated module. It adds macOS backing-color control, render-readiness signaling, window reveal and focus handling, and geometry stabilization polling with timeout logging.

Changes

Initial Window Handling

Layer / File(s) Summary
Initial-window reveal and stabilization
desktop/src-tauri/src/initial_window.rs
Adds the render-ready event constant, window reveal and focus helper, macOS backing-color helpers, and geometry polling with stability and timeout conditions.
Initial-window module integration
desktop/src-tauri/src/lib.rs
Registers the private initial_window module and imports its functionality.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: tlongwell-block, wpfleger96

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v0.5.4-desktop-size

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant