Replace use of ActiveRecord::Base.connection with with_connection - #652
Merged
Conversation
So that when running with `permanent_connection_checkout` set to `false`, this doesn't cause any problems. Using `connection` is deprecated in any case, so this was needed regardless.
|
Awesome, thanks! |
rosa
pushed a commit
that referenced
this pull request
Jul 27, 2026
…nnection` Bare `connection` resolves to the deprecated ActiveRecord::Base.connection, which raises under permanent_connection_checkout = :disallowed on Rails 8.1. Follows the connection_pool.with_connection pattern from #652.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that when running with
permanent_connection_checkoutset tofalse, this doesn't cause any problems. Usingconnectionis deprecated in any case, so this was needed regardless.Fixes #646