Skip to content

Wait for the continuable job to start before interrupting it #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosa merged 1 commit into from
Jul 24, 2026
+5 −1
Merged

Wait for the continuable job to start before interrupting it #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/dummy/app/jobs/continuable_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ class ContinuableJob < ApplicationJob

def perform(result, pause: 0)
step :step_one do
result.update!(queue_name: queue_name, status: "started", value: "step_one")
sleep pause if pause > 0
result.update!(queue_name: queue_name, status: "stepped", value: "step_one")
end
Expand Down
5 changes: 4 additions & 1 deletion test/integration/continuation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ def setup
test "continuable job can be interrupted and resumed" do
job = ContinuableJob.perform_later(@result, pause: 0.5.seconds)

sleep 0.2.seconds
# Wait for step_one to have started before signaling TERM, so the signal
# always arrives while the job is paused inside step_one and the interruption
# lands between the two steps
wait_while_with_timeout(3.seconds) { !JobResult.exists?(status: "started", value: "step_one") }
signal_process(@pid, :TERM)

wait_for_jobs_to_be_released_for(2.seconds)
Expand Down
Loading