Keep concurrency locks across non-graceful job release - #771
Open
rafael-pissardo wants to merge 1 commit into
Open
Keep concurrency locks across non-graceful job release#771rafael-pissardo wants to merge 1 commit into
rafael-pissardo wants to merge 1 commit into
Conversation
When a claimed concurrency-limited job is released back to ready after a force-kill, its semaphore could expire and maintenance could unblock another job for the same key while the released job was still ready. Workers then claimed both and broke limits_concurrency. Extend the lock on release, skip expiring semaphores still held by ready jobs, run concurrency maintenance synchronously at supervisor boot and dispatcher start, and cover the race with unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #735.
Test plan
TARGET_DB=sqlite bundle exec ruby -Itest test/unit/concurrency_maintenance_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/integration/concurrency_controls_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/models/solid_queue/claimed_execution_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/unit/dispatcher_test.rbTARGET_DB=sqlite bundle exec ruby -Itest test/unit/fork_supervisor_test.rb