Merged
Conversation
estebanmino
requested review from
brunobar79,
derHowie and
greg-schrammel
and removed request for
brunobar79
BX-1131 eth_estimateGas returning BigNumber instead of string
grant said:
|
greg-schrammel
approved these changes
Nov 30, 2023
Contributor
greg-schrammel
left a comment
greg-schrammel
left a comment
There was a problem hiding this comment.
lol I think I just errored on 1inch because of it this morning
Contributor
|
Here's the packed extension for this build: |
brunobar79
approved these changes
Dec 4, 2023
Contributor
|
Here's the packed extension for this build: |
Contributor
|
Here's the packed extension for this build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
returning string values for
eth_estimateGasandeth_gasPriceprovider requestsScreen recordings / screenshots
What to test