Skip to content

feat: contacts#1526

Merged
DanielSinclair merged 18 commits intomasterfrom
mago/contacts
May 9, 2024
Merged

feat: contacts#1526
DanielSinclair merged 18 commits intomasterfrom
mago/contacts

Conversation

@0xmkh
Copy link
Contributor

@0xmkh 0xmkh commented Apr 29, 2024

Fixes BX-1429
Figma link (if any):

Screen recordings / screenshots

contacts.mov

What to test

  • Make sure you can add contacts for any current wallets in Cmd+K menu for My Wallets tab
  • When you add a contact make sure you can't add the same contact twice in My Wallets tab
  • You should see your recent added contacts in My Contacts section in Cmd+K menu
  • If you were to click on a contact or press Enter you should be redirected to /send page and the from address should be the contact address
image
  • Test out different contact actions for a contact (Watch wallet, send, remove contact, copy and view on etherscan)
image
  • Bonus. Currently there is a bug in production where if you add a contact without a name it shows you a blank state, in this PR it should fix that ✅
image

@linear
Copy link

linear bot commented Apr 29, 2024

BX-1429 Contacts in CmdK

@github-actions
Copy link
Contributor

Here's the packed extension for this build:
rainbowbx-c24eb51c4590d0805b11aa61395c8c9d3c2bd0ee.zip

@github-actions
Copy link
Contributor

Here's the packed extension for this build:
rainbowbx-cf058eed374201f83f81c6b9d3bdf4f4fe5868c7.zip

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-dc22839c747e52f75ea23016d12cd93c0d3c7370

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ff2742fb4c168e4e914003305705a899bbd24fce

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, i tried to break it but seems to be working as expected 💯

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Here's the packed extension for this build:
rainbowbx-a766e354b4ca4ed33b7934de9cd3d9cf37f98fc6

@0xmkh 0xmkh added this pull request to the merge queue May 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 3, 2024
@0xmkh 0xmkh added this pull request to the merge queue May 3, 2024
@0xmkh 0xmkh removed this pull request from the merge queue due to a manual request May 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-fe5afa39dbf435ebf74b405da1cf4fe4fd2d9881

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Here's the packed extension for this build:
rainbowbx-fe5afa39dbf435ebf74b405da1cf4fe4fd2d9881

@0xmkh 0xmkh added this pull request to the merge queue May 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 3, 2024
@0xmkh 0xmkh added this pull request to the merge queue May 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0c393a55e3c5afd59bc1a9ba9af313252693347c

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-29d97c5fe45346bcd9d6df1a4799d065f6b58468

@DanielSinclair DanielSinclair enabled auto-merge May 9, 2024 06:21
@DanielSinclair DanielSinclair added this pull request to the merge queue May 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Here's the packed extension for this build:
node_modules.tar.gz

Merged via the queue into master with commit 4eabe4a May 9, 2024
@DanielSinclair DanielSinclair deleted the mago/contacts branch May 9, 2024 06:35
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2024

Here's the packed extension for this build:
node_modules.tar.gz

@DanielSinclair
Copy link
Collaborator

DanielSinclair commented May 9, 2024

@magiziz There was an odd race condition when the merge queue had merged this (with CI failing? wut?) that broke CI. Pushed up a CI fix here: #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants