Skip to content

Add default slippage to remote config#3749

Merged
jinchung merged 2 commits into
@bruno/rainbow-swapsfrom
@bruno/remote-default-slippage
Jul 19, 2022
Merged

Add default slippage to remote config#3749
jinchung merged 2 commits into
@bruno/rainbow-swapsfrom
@bruno/remote-default-slippage

Conversation

@brunobar79
Copy link
Copy Markdown
Contributor

Fixes RNBW-####
Figma link (if any):

What changed (plus any additional context for devs)

Added default slippage to remote config

Screen recordings / screenshots

Jumped on a call with @estebanmino to verify this works properly

What to test

You can change the value in the remote config, restart the app and it should be reflected in the slippage settings

Final checklist

  • Assigned individual reviewers?
  • Added labels? (team1/team2, critical path, release, dev QA)
  • Did you test both iOS and Android?
  • If your changes are visual, did you check both the light and dark themes?
  • Added e2e tests? If not, please specify why
  • If you added new critical path files, did you update the CODEOWNERS file?
  • If no dev QA label, did you add the PR to the QA Queue?

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants