Skip to content

feat(apps): rename +list --scope flag to --ownership - #47

Merged
raistlin042 merged 3 commits into
feat/lark-apps-devfrom
feat/apps-list-ownership
Jun 9, 2026
Merged

feat(apps): rename +list --scope flag to --ownership#47
raistlin042 merged 3 commits into
feat/lark-apps-devfrom
feat/apps-list-ownership

Conversation

@raistlin042

Copy link
Copy Markdown
Owner

Summary

apps +list previously exposed a --scope collaborator filter (enum all / created_by_me / shared_with_me) and forwarded it to the backend as the scope request param. The backend contract has moved this to ownership with shorter enum values. This PR renames the CLI flag and request param to ownership (all / mine / shared), a clean replacement with no --scope alias.

Also de-conflicts naming: the old --scope collided semantically with the apps domain's +access-scope-* (runtime visibility) commands.

Changes

  • Rename --scope flag to --ownership (enum all/mine/shared) and forward as the ownership request param in shortcuts/apps/apps_list.go; doc comment updated. Values pass through directly (flag value == backend value, no mapping table); empty value is still omitted so the server applies its all default.
  • Update unit tests in shortcuts/apps/apps_list_test.go (URL assertion scope=created_by_meownership=mine; invalid-enum and dry-run cases).
  • Update built-in cli_e2e dry-run test and coverage doc in tests/cli_e2e/apps/apps_list_dryrun_test.go and tests/cli_e2e/apps/coverage.md.
  • Document the new flag in skills/lark-apps/references/lark-apps-list.md.

Test Plan

  • go test ./shortcuts/apps/... passed
  • validate passed (build / vet / unit / integration)
  • local-eval skipped: lite mode (no sandbox); ran built-in cli_e2e dry-run regression locally instead — TestAppsListDryRun 8/8 passed; skillave N/A (no shortcut behavior / AI-decision-point change)
  • acceptance-reviewer passed (2/2 scenarios + 5 exploratory sub-cases)
  • manual verification: lark-cli apps +list --ownership mine --dry-runapi.0.params.ownership = "mine"; --ownership bogus and removed --scope both rejected with structured error (exit 2)

Related Issues

N/A

@raistlin042 raistlin042 added feature New functionality breaking-change Incompatible changes labels Jun 9, 2026
@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jun 9, 2026
@raistlin042
raistlin042 merged commit e0a182e into feat/lark-apps-dev Jun 9, 2026
1 check passed
@raistlin042
raistlin042 deleted the feat/apps-list-ownership branch June 9, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Incompatible changes feature New functionality size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant