Enabling support for non-Spring launching, documentation#58
Open
wdile wants to merge 1 commit intorampatra:masterfrom
Open
Enabling support for non-Spring launching, documentation#58wdile wants to merge 1 commit intorampatra:masterfrom
wdile wants to merge 1 commit intorampatra:masterfrom
Conversation
2009aba to
392b445
Compare
Signed-off-by: William Dunne <william@tutuka.com>
392b445 to
85b197d
Compare
Owner
|
Thank you very much @wildunne for your time and work, I will keep this PR open so if someone wants to use JBot without spring-boot can follow your tips but unfortunately, I created this as a spring-boot library and I have planned to add many more features in the near future which uses spring. So I cannot merge your PR to master as of now. If later things change then for sure, I will merge it. Hope that's okay with you! |
Author
|
Fine with me, I managed to get around all of this using reflection tricks, it just seems like an odd way for things to be built because it makes it difficult to build anything that will be used by more than one team (at least this is the case as far as I can see) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I was experimenting with JBot and found it difficult to launch a bot in a non-spring based application
What
The changes (almost exclusively to the privacy of the fields) allow you to create the Bot object and launch it yourself without the assistance of Spring.
I apologize if you don't like the style of documentation, it isn't exactly my strong point.