Enforce ErrInsufficientBalance for Asset and Expense accounts#2
Merged
raphi011 merged 2 commits intoFeb 28, 2026
Merged
Conversation
Add defined types (LedgerID, SubledgerID, AccountID, TransactionID, EntryID, HoldID) so map keys and method parameters clearly communicate what kind of identifier they expect. These are defined types (not aliases), giving compile-time safety against mixing e.g. a HoldID where an AccountID is expected. Change all public Service methods to return value types instead of pointers to internal state. This prevents callers from accidentally mutating the service's data. Transaction returns use a deep copy helper (copyTransaction) that copies the Entries slice and Metadata map. GetSnapshot now returns ErrSnapshotNotFound instead of nil when no snapshot exists for the given parameters. https://claude.ai/code/session_01947Cs6jqVPDDzmAqQMoB35
PostTransaction and CreateHold now check that the available balance (book minus active holds) would not go negative for Asset and Expense accounts. Liability, Equity, and Revenue accounts are not checked. https://claude.ai/code/session_01947Cs6jqVPDDzmAqQMoB35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.