Skip to content

Small code refactor#3

Closed
natdm wants to merge 4 commits into
rapidloop:masterfrom
natdm:code_refactor
Closed

Small code refactor#3
natdm wants to merge 4 commits into
rapidloop:masterfrom
natdm:code_refactor

Conversation

@natdm

@natdm natdm commented Oct 16, 2016

Copy link
Copy Markdown

Small code refactor, hope you don't mind :-) Most are to be idiomatic, one to fix a possible app crash.

All changes on slack.go

  • Deferred the body close
  • Imbedded responseSelf to responseRtmStart since it's only being used once
  • Changed Id to ID and Url to URL
  • Changed 200 to http.StatusOK

@natdm natdm changed the title Small code refactor, fixed possible crash Small code refactor Oct 16, 2016
@PhillippOhlandt

Copy link
Copy Markdown

Hey, I applied the PR to my repo clone and got an error message when I invite my bot into a channel, see #4

@natdm natdm closed this Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants