Correct install path for include folder to avoid double nesting#1630
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.06from Jun 1, 2021
Merged
Correct install path for include folder to avoid double nesting#1630rapids-bot[bot] merged 1 commit intorapidsai:branch-21.06from
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.06from
Conversation
ChuckHastings
approved these changes
May 27, 2021
robertmaynard
approved these changes
May 27, 2021
seunghwak
approved these changes
May 27, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #1630 +/- ##
===============================================
Coverage ? 59.75%
===============================================
Files ? 79
Lines ? 3484
Branches ? 0
===============================================
Hits ? 2082
Misses ? 1402
Partials ? 0 Continue to review full report at Codecov.
|
trxcllnt
approved these changes
May 28, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to rapidsai/cuml#3901.
After #1491 and #rapids-cmake and #1585, now at install time, the cugraph headers are being nested into
path/to/env/include/cugraph/cugraphinstead of justpath/to/env/include/cugraph/. This, as far as I'm aware, is unintentional and unlike the rest of RAPIDS projects (cuDF, RMM and cuML).cc @trxcllnt @robertmaynard