Skip to content

Upgraded recipe and dev envs to NCCL 2.9.9#1636

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.06from
rlratzel:branch-21.06-ncclupdate
Jun 3, 2021
Merged

Upgraded recipe and dev envs to NCCL 2.9.9#1636
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.06from
rlratzel:branch-21.06-ncclupdate

Conversation

@rlratzel
Copy link
Contributor

Upgraded recipe and dev envs to NCCL 2.9.9.

The cugraph python conda recipe previously included NCCL, but (I think) it's a transient dependency since libcugraph actually needs it, so it was removed from the cugraph recipe.

cc @dantegd for consistency with cuML.

Note: the NCCL 2.9.9 upgrade was tested during benchmark runs, but the conda recipe changes have not been tested.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 30, 2021
@rlratzel rlratzel added this to the 21.06 milestone May 30, 2021
@rlratzel rlratzel requested a review from ChuckHastings May 30, 2021 03:06
@rlratzel rlratzel self-assigned this May 30, 2021
@rlratzel rlratzel requested a review from a team as a code owner May 30, 2021 03:06
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@45a50aa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1636   +/-   ##
===============================================
  Coverage                ?   60.80%           
===============================================
  Files                   ?       80           
  Lines                   ?     3615           
  Branches                ?        0           
===============================================
  Hits                    ?     2198           
  Misses                  ?     1417           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a50aa...def2596. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@BradReesWork
Copy link
Member

rerun tests

@rapids-bot rapids-bot bot merged commit 0d20a8b into rapidsai:branch-21.06 Jun 3, 2021
rapids-bot bot pushed a commit that referenced this pull request Jun 4, 2021
Should be merged after PR #1636.

- Undo NCCL 2.9.6 bug workarounds.
- MG WCC weak scaling improvements.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Andrei Schaffer (https://github.com/aschaffer)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #1628
@rlratzel rlratzel deleted the branch-21.06-ncclupdate branch June 17, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants