[FIX] CHECK_CUDA macros in debug builds#1687
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-21.08from Jun 28, 2021
Merged
[FIX] CHECK_CUDA macros in debug builds#1687rapids-bot[bot] merged 3 commits intorapidsai:branch-21.08from
CHECK_CUDA macros in debug builds#1687rapids-bot[bot] merged 3 commits intorapidsai:branch-21.08from
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1687 +/- ##
================================================
+ Coverage 59.77% 59.99% +0.22%
================================================
Files 80 80
Lines 3540 3542 +2
================================================
+ Hits 2116 2125 +9
+ Misses 1424 1417 -7
Continue to review full report at Codecov.
|
BradReesWork
added
improvement
seunghwak
approved these changes
Jun 25, 2021
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
We're switching from cudaStream_t to rmm::cuda_stream_view, so I think we need to eventually update CHECK_CUDA to take rmm::cuda_stream_view, but at this moment, this looks like a proper fix.
ChuckHastings
approved these changes
Jun 26, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.