Skip to content

replace cudf assert_eq#1693

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-21.08from
jnke2016:replace_cudf_assert_eq
Jul 13, 2021
Merged

replace cudf assert_eq#1693
rapids-bot[bot] merged 4 commits intorapidsai:branch-21.08from
jnke2016:replace_cudf_assert_eq

Conversation

@jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Jul 1, 2021

replace cudf assert_eq by assert_frame_equal which is more stable

@jnke2016 jnke2016 requested a review from a team as a code owner July 1, 2021 22:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@1a63602). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1693   +/-   ##
===============================================
  Coverage                ?   59.34%           
===============================================
  Files                   ?       80           
  Lines                   ?     3559           
  Branches                ?        0           
===============================================
  Hits                    ?     2112           
  Misses                  ?     1447           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a63602...63e1889. Read the comment docs.

@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 6, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jul 6, 2021
@BradReesWork BradReesWork requested review from Iroy30 and rlratzel July 6, 2021 20:36
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2b7d02f into rapidsai:branch-21.08 Jul 13, 2021
@jnke2016 jnke2016 deleted the replace_cudf_assert_eq branch September 24, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants