[FIX] Always add faiss library alias if it's missing#1694
Closed
trxcllnt wants to merge 2 commits intorapidsai:branch-21.08from
Closed
[FIX] Always add faiss library alias if it's missing#1694trxcllnt wants to merge 2 commits intorapidsai:branch-21.08from
faiss library alias if it's missing#1694trxcllnt wants to merge 2 commits intorapidsai:branch-21.08from
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1694 +/- ##
===============================================
Coverage ? 59.31%
===============================================
Files ? 80
Lines ? 3557
Branches ? 0
===============================================
Hits ? 2110
Misses ? 1447
Partials ? 0 Continue to review full report at Codecov.
|
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Jul 6, 2021
Always add the `FAISS::FAISS` library target alias if it doesn't exist. This can happen if cuGraph is built and installs FAISS before cuML. rapidsai/cugraph#1694 Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: #4028
BradReesWork
added
improvement
ChuckHastings
approved these changes
Jul 6, 2021
Collaborator
ChuckHastings
left a comment
ChuckHastings
left a comment
There was a problem hiding this comment.
Looks fine to me.
Why do we need FAISS?
Collaborator
Author
|
@ChuckHastings it's a raft dependency, though now that you mention it looks like raft needs this change too. And if raft gets it, we can probably remove cuML's and cuGraph's |
Member
|
@trxcllnt if we can put this in RAFT it would make more sense and solve both graph and ml. Putting this PR on hold until you respond |
BradReesWork
added
4 - Waiting on Author
DO NOT MERGE
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
…etting UCX install location (#1698) This PR is a continuation of #1694. Similar to rapidsai/cuml#4015, this PR updates setup.py to: * Use `library_dirs` instead of `runtime_library_dirs` when linking Cython. * Allow overriding UCX lib and include dirs via a `UCX_HOME` envvar. * Link `cudart`, `cusparse`, and `cusolver`. These are necessary to compile the Cython via `pip` when not inside a conda environment and when UCX is installed to a location other than `/usr` or `/usr/local`. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #1698
Collaborator
Author
|
@BradReesWork The RAFT PR is here: rapidsai/raft#287. This commit was included in PR #1698, so I'll close this one. |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Jul 9, 2021
Always add the `FAISS::FAISS` library target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph or vice-versa. Related PRs: rapidsai/cuml#4028 rapidsai/cugraph#1694 Note: We can probably remove the `get_faiss.cmake` file in cuML and cuGraph since they both should get it from RAFT. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) URL: #287
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Always add the `FAISS::FAISS` library target alias if it doesn't exist. This can happen if cuGraph is built and installs FAISS before cuML. rapidsai/cugraph#1694 Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#4028
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
Always add the `FAISS::FAISS` library target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph or vice-versa. Related PRs: rapidsai/cuml#4028 rapidsai/cugraph#1694 Note: We can probably remove the `get_faiss.cmake` file in cuML and cuGraph since they both should get it from RAFT. Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always add the
FAISS::FAISSlibrary target alias if it doesn't exist. This can happen if cuML is built and installs FAISS before cuGraph.rapidsai/cuml#4028