Fix the Louvain failure with 64 bit vertex IDs#1696
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.08from Jul 9, 2021
Merged
Fix the Louvain failure with 64 bit vertex IDs#1696rapids-bot[bot] merged 2 commits intorapidsai:branch-21.08from
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.08from
Conversation
seunghwak
added
3 - Ready for Review
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1696 +/- ##
===============================================
Coverage ? 59.34%
===============================================
Files ? 80
Lines ? 3559
Branches ? 0
===============================================
Hits ? 2112
Misses ? 1447
Partials ? 0 Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Jul 6, 2021
…to bug_louvain_64bit
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Louvain currently crashes with 64 bit vertex ID (thrust::copy with thrust::make_transform_iterator and a device lambda returns cudaErrorInvalidDeviceFunction). This PR fixes this error (replaces the device lambda with a
struct minor_to_key_tfunctor).