Skip to content

Fix libfaiss dependency to not expressly depend on conda-forge#1728

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.08from
jjacobelli:fix-libfaiss
Jul 22, 2021
Merged

Fix libfaiss dependency to not expressly depend on conda-forge#1728
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.08from
jjacobelli:fix-libfaiss

Conversation

@jjacobelli
Copy link
Contributor

No description provided.

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 22, 2021
@jjacobelli jjacobelli requested a review from a team July 22, 2021 14:51
@jjacobelli jjacobelli self-assigned this Jul 22, 2021
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this, @ethyling. It was on my TODO list so I'm happy to see it done.

@jjacobelli
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@49aaff6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1728   +/-   ##
===============================================
  Coverage                ?   59.75%           
===============================================
  Files                   ?       77           
  Lines                   ?     3523           
  Branches                ?        0           
===============================================
  Hits                    ?     2105           
  Misses                  ?     1418           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49aaff6...4aadbb8. Read the comment docs.

@rapids-bot rapids-bot bot merged commit e5b3599 into rapidsai:branch-21.08 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants