Skip to content

[REVIEW] Biased Random Walks for GNN#1732

Merged
rapids-bot[bot] merged 59 commits intorapidsai:branch-21.10from
aschaffer:fea_biased_rw
Aug 12, 2021
Merged

[REVIEW] Biased Random Walks for GNN#1732
rapids-bot[bot] merged 59 commits intorapidsai:branch-21.10from
aschaffer:fea_biased_rw

Conversation

@aschaffer
Copy link
Collaborator

This tracks work on implementing Biased Random Walks for GNN.

aschaffer and others added 21 commits November 30, 2020 15:00
Update forked branch-0.18 from release
Update branch-0.19 from release
update forked from release branch-0.19
Merge from release branch-0.19
Merge latest rapidsai:branch-0.19 into aschaffer:branch-0.19
merge latest release branch-0.20
Merge latest rapidsai/branch-0.20 into forked branch-0.20
aschaffer/21.08 <- rapidsai/21.08
@aschaffer aschaffer requested a review from a team as a code owner July 24, 2021 02:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@0fb1724). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1732   +/-   ##
===============================================
  Coverage                ?   59.60%           
===============================================
  Files                   ?       77           
  Lines                   ?     3533           
  Branches                ?        0           
===============================================
  Hits                    ?     2106           
  Misses                  ?     1427           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb1724...776997e. Read the comment docs.

@aschaffer aschaffer changed the title [WIP] Biased Random Walks for GNN [REVIEW] Biased Random Walks for GNN Aug 11, 2021
@BradReesWork BradReesWork requested a review from seunghwak August 11, 2021 15:21
BoolT init{1};
return thrust::transform_reduce(
thrust::device,
rmm::exec_policy(handle.get_stream_view()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the below, you're checking only in case if (col_indx > row_indx) {.

Is this sufficient?

Say row_indx is 3. Will this cover the case row_indx, col_indx = (3, 2) exists but (2, 3) missing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is an old function, to which I only changed the exec policy to make it compliant to rmm. I'd have to double check.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 67d2d98 into rapidsai:branch-21.10 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants