Changed cuco cmake function to return early if cuco has already been added as a target#1746
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.08from Jul 29, 2021
Conversation
…added as a target.
ChuckHastings
approved these changes
Jul 29, 2021
dillon-cullinan
approved these changes
Jul 29, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed cuco cmake function to return early if cuco has already been added as a target. This matches the technique used by raft here.
Tested by doing a build and install of cuML, followed by a build of cuGraph and observing a CPM error about the alias target
cuco::cucoalready existing. Made the change to return early if cuco is already a target and observed the cuGraphlibcugraph.sobuild succeed.