Skip to content

MNMG memory footprint improvement for low average vertex degree graphs (part 2)#1774

Merged
rapids-bot[bot] merged 17 commits intorapidsai:branch-21.10from
seunghwak:enh_mem_req_part2
Aug 23, 2021
Merged

MNMG memory footprint improvement for low average vertex degree graphs (part 2)#1774
rapids-bot[bot] merged 17 commits intorapidsai:branch-21.10from
seunghwak:enh_mem_req_part2

Conversation

@seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Aug 13, 2021

This PR has the following 2 updates.

  1. Update the type of the create_graph_from_edgelist functions's optional vertex list input parameter from std::tuple of a pointer and the array size to rmm::device_uvector r-value (to be consistent with the edge list input parameters and to allow releasing the memory earlier).
  2. Avoid storing counts (vertex degrees) for isolated vertices (which implicitly have 0 degrees) to save memory.

@seunghwak seunghwak requested a review from a team as a code owner August 13, 2021 20:55
@seunghwak seunghwak added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function multi-GPU non-breaking Non-breaking change labels Aug 13, 2021
@BradReesWork BradReesWork added this to the 21.10 milestone Aug 16, 2021
@seunghwak seunghwak changed the title [skip-ci] MNMG memory footprint improvement for low average vertex degree graphs (part 2) MNMG memory footprint improvement for low average vertex degree graphs (part 2) Aug 17, 2021
@seunghwak seunghwak added 3 - Ready for Review and removed DO NOT MERGE Hold off on merging; see PR for details labels Aug 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@7565dc3). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4c800d2 differs from pull request most recent head 7caf341. Consider uploading reports for the commit 7caf341 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1774   +/-   ##
===============================================
  Coverage                ?   59.70%           
===============================================
  Files                   ?       77           
  Lines                   ?     3541           
  Branches                ?        0           
===============================================
  Hits                    ?     2114           
  Misses                  ?     1427           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7565dc3...7caf341. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 59f6fdd into rapidsai:branch-21.10 Aug 23, 2021
@seunghwak seunghwak deleted the enh_mem_req_part2 branch October 19, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants