Temporarily pin RMM while refactor removes deprecated calls#1775
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-21.10from Aug 17, 2021
Merged
Temporarily pin RMM while refactor removes deprecated calls#1775rapids-bot[bot] merged 4 commits intorapidsai:branch-21.10from
rapids-bot[bot] merged 4 commits intorapidsai:branch-21.10from
Conversation
dantegd
changed the title
BradReesWork
added
! - Hotfix
non-breaking
BradReesWork
approved these changes
Aug 16, 2021
Member
|
rerun tests |
Member
Author
|
@BradReesWork just realized that the RAFT PR rapidsai/raft#315 needs to be merged first so that this one passes CI |
rlratzel
approved these changes
Aug 16, 2021
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Thanks! One minor request if possible, which need not hold up approval.
rlratzel
approved these changes
Aug 17, 2021
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Thanks for updating the conda files too, that should cover everything now.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1775 +/- ##
===============================================
Coverage ? 59.63%
===============================================
Files ? 77
Lines ? 3535
Branches ? 0
===============================================
Hits ? 2108
Misses ? 1427
Partials ? 0 Continue to review full report at Codecov.
|
Member
|
@gpucibot merge |
ajschmidt8
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unblock build locally and in CI. Needs to be undone after #1707 is merged.
cc @ChuckHastings