Split many files to separate SG from MG template instantiations#1803
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1803 +/- ##
=================================================
+ Coverage 59.85% 71.95% +12.09%
=================================================
Files 77 134 +57
Lines 3547 8332 +4785
=================================================
+ Hits 2123 5995 +3872
- Misses 1424 2337 +913
Continue to review full report at Codecov.
|
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Looks good to me except for few places git mv can be used instead of deleting and re-creating a file.
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Are you splitting the below louvain.cu file to this louvain.cu and the below louvain_impl.cuh? If it's the case, at least one of the new flies (preferably the longer one) should be created using git mv (instead of deleting and creating) to better preserve the history.
There was a problem hiding this comment.
I used git mv. If I check out this branch and do a git log on the files it shows the history. I believe this is a bug in the git web presentation.
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Please use git mv (assuming that this is based on the above deleted create_graph_from_edgelist.cpp) instead of deleting and newly creating a file.
There was a problem hiding this comment.
Same as above.
There was a problem hiding this comment.
I see, then, let's wish there is no other PR updating this file (I checked few PRs and haven't found), and let's merge this PR ASAP (and ask other PRs to sync with the main branch). If multiple PRs touch this PR (and if this isn't just a web presentation issue), things can become a mess.
|
@gpucibot merge |
3 participants
Partially addresses #1770
This is preliminary work to separate the SG and MG shared object libraries. This PR splits many of the source files that instantiate SG and MG variants of algorithms/objects/functions.
There will be subsequent PRs that will refactor the CMake structure and probably move some more files around.