Skip to content

Also building cpp MG tests as part of conda/CI libcugraph builds#1805

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-21.10from
rlratzel:branch-21.10-alwaysenablemgtestbuilds
Sep 4, 2021
Merged

Also building cpp MG tests as part of conda/CI libcugraph builds#1805
rapids-bot[bot] merged 6 commits intorapidsai:branch-21.10from
rlratzel:branch-21.10-alwaysenablemgtestbuilds

Conversation

@rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Sep 2, 2021

Also building cpp MG tests as part of conda/CI libcugraph builds.

This addresses recent issues where commits were merged that broke MG test builds that were not caught in CI.

Tested locally using both a CentOS and Ubuntu gpuCI container to run the same build command in the recipe, but did not run the actual conda build command on the recipe. This required additional system packages to be installed in the gpuCI containers:
CentOS:

yum install openmpi-devel
export PATH=/usr/lib64/openmpi/bin:$PATH

Ubuntu:

apt install libopenmpi-dev openmpi-bin

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 2, 2021
@rlratzel rlratzel self-assigned this Sep 2, 2021
@rlratzel rlratzel requested a review from a team as a code owner September 2, 2021 20:52
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (assuming it passes CI :-) )

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but CI won't pass until the latest package installation changes are published. Should be done within an hour or two.

@rlratzel
Copy link
Contributor Author

rlratzel commented Sep 3, 2021

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #1805 (5af7eff) into branch-21.10 (bf64c2c) will increase coverage by 9.80%.
The diff coverage is n/a.

❗ Current head 5af7eff differs from pull request most recent head 854c2f2. Consider uploading reports for the commit 854c2f2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1805      +/-   ##
================================================
+ Coverage         59.85%   69.66%   +9.80%     
================================================
  Files                77      139      +62     
  Lines              3547     8613    +5066     
================================================
+ Hits               2123     6000    +3877     
- Misses             1424     2613    +1189     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.80% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.47% <ø> (ø)
python/cugraph/cugraph/comms/comms.py 34.52% <ø> (ø)
python/cugraph/cugraph/community/__init__.py 70.37% <ø> (ø)
python/cugraph/cugraph/community/ecg.py 100.00% <ø> (ø)
python/cugraph/cugraph/community/egonet.py 92.30% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 84.37% <ø> (ø)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31317ef...854c2f2. Read the comment docs.

@rlratzel
Copy link
Contributor Author

rlratzel commented Sep 4, 2021

@gpucibot merge

@rlratzel
Copy link
Contributor Author

rlratzel commented Sep 4, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit dcc08bc into rapidsai:branch-21.10 Sep 4, 2021
@rlratzel rlratzel deleted the branch-21.10-alwaysenablemgtestbuilds branch June 17, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants