Changed pylibcugraph connected_components APIs to use duck typing for CAI inputs, added doc placeholders#1810
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.10from Sep 10, 2021
Conversation
…hon file, changed API to use duck-typing on __cuda_array_interface__ types, updated tests, added test for invalid inputs.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1810 +/- ##
================================================
+ Coverage 59.85% 69.70% +9.85%
================================================
Files 77 139 +62
Lines 3547 8626 +5079
================================================
+ Hits 2123 6013 +3890
- Misses 1424 2613 +1189
Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Sep 10, 2021
raydouglass
approved these changes
Sep 10, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__cuda_array_interface__types instead of requiring users to access and pass the__cuda_array_interface__object in directly.__cuda_array_interface__attr directly, added fixtures for easier code reuse, added test for invalid inputs, added FIXMEs to track tech debt in how return values are checked.Tested API changes by running new unit tests, and tested docs by running
./build.sh docsand inspecting the html locally in a browser.NOTE: since this package is still limited to nightly releases (ie. it has not been part of a release yet), it is using the "non-breaking" label even though the user API has changed.
attn: @BradReesWork and @raydouglass for the


pylibcugraphplaceholder docs in this PR