Skip to content

Make sure we keep the rapids-cmake and cugraph cal version in sync#1830

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.10from
robertmaynard:keep_rapids-cmake-version-in-sync
Sep 21, 2021
Merged

Make sure we keep the rapids-cmake and cugraph cal version in sync#1830
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.10from
robertmaynard:keep_rapids-cmake-version-in-sync

Conversation

@robertmaynard
Copy link
Contributor

When we make a new cugraph version, we need to also bump the rapids-cmake version at the same time. Otherwise we will get the previous releases dependencies by mistake.

when we make a new cugraph version, we need to also bump the rapids-cmake version at the
same time. Otherwise we will get the previous releases dependencies by mistake.
@robertmaynard robertmaynard requested a review from a team as a code owner September 20, 2021 17:21
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #1830 (b2cdfe6) into branch-21.10 (bf64c2c) will increase coverage by 9.72%.
The diff coverage is n/a.

❗ Current head b2cdfe6 differs from pull request most recent head 04d5abd. Consider uploading reports for the commit 04d5abd to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1830      +/-   ##
================================================
+ Coverage         59.85%   69.57%   +9.72%     
================================================
  Files                77      139      +62     
  Lines              3547     8645    +5098     
================================================
+ Hits               2123     6015    +3892     
- Misses             1424     2630    +1206     
Impacted Files Coverage Δ
python/cugraph/link_analysis/hits.py
python/cugraph/link_prediction/overlap.py
python/cugraph/link_prediction/woverlap.py
python/cugraph/cores/k_core.py
python/cugraph/structure/number_map.py
python/cugraph/dask/common/read_utils.py
python/cugraph/link_analysis/pagerank.py
python/cugraph/structure/graph_classes.py
python/cugraph/dask/components/connectivity.py
python/cugraph/tree/minimum_spanning_tree.py
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032f86a...04d5abd. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.10 milestone Sep 21, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4e457dc into rapidsai:branch-21.10 Sep 21, 2021
@robertmaynard robertmaynard deleted the keep_rapids-cmake-version-in-sync branch September 21, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants