Removed NetworkX requirement for type checks, fixed docstring, added new docstrings, import cleanups#1853
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-21.10from Sep 28, 2021
Conversation
…or Nx types without requiring Nx.
…0-doc_and_nx_import_fix
… type checking code, added docstrings for pylibcugraph.CC functions.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1853 +/- ##
================================================
+ Coverage 69.59% 70.08% +0.49%
================================================
Files 143 143
Lines 8675 8819 +144
================================================
+ Hits 6037 6181 +144
Misses 2638 2638
Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Sep 28, 2021
…rt in BC for consistency.
jnke2016
approved these changes
Sep 28, 2021
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import_optionalto useimportlibinstead, and returnMissingModuleinstances for easier error reporting.rmatdocstring [DOC] RMAT documentation example is badly formatted. #1807pylibcugraph*_connected_componentsAPIs. [FEA] initialpylibcugraphsupport #1782Tested changes to optional import and type checking code by uninstalling
NetworkX, observing the failure shown in #1851, applying change, then testing to observe the same script runs to completion without Nx installed.closes #1851
closes #1807
closes #1782