Copy v transform reduce out test#1856
Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-21.12from Oct 15, 2021
Merged
Conversation
Fixed bug in copy_v_transform_reduce_in_out_nbr kernels
seunghwak
added
improvement
kaatish
added
Graph Prims
and removed
improvement
seunghwak
reviewed
Sep 28, 2021
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Shouldn't we have a test for in_nbr as well?
Besides this & (some minor issues about formatting), this looks great to me.
Collaborator
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1856 +/- ##
===============================================
Coverage ? 70.08%
===============================================
Files ? 143
Lines ? 8817
Branches ? 0
===============================================
Hits ? 6179
Misses ? 2638
Partials ? 0 Continue to review full report at Codecov.
|
Initial value was not being set correctly. This commit fixes it.
seunghwak
reviewed
Sep 30, 2021
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Looks great besides few minor cosmetic issues.
And thanks a lot for finding & fixing the bug related to handling initial values.
seunghwak
reviewed
Sep 30, 2021
…v_transform_reduce_out_test
…v_transform_reduce_out_test
Member
|
rerun tests |
Collaborator
|
@rerun tests |
ChuckHastings
approved these changes
Oct 8, 2021
Member
|
rerun tests |
1 similar comment
Collaborator
|
rerun tests |
Collaborator
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.