Skip to content

[REVIEW] node2vec Sampling Implementation#1875

Merged
rapids-bot[bot] merged 44 commits intorapidsai:branch-21.12from
aschaffer:fea_ext_node2vec
Oct 28, 2021
Merged

[REVIEW] node2vec Sampling Implementation#1875
rapids-bot[bot] merged 44 commits intorapidsai:branch-21.12from
aschaffer:fea_ext_node2vec

Conversation

@aschaffer
Copy link
Collaborator

This tracks work on implementing Random Walks using node2vec sampling method.

Update forked branch-0.18 from release
Update branch-0.19 from release
update forked from release branch-0.19
Merge from release branch-0.19
Merge latest rapidsai:branch-0.19 into aschaffer:branch-0.19
merge latest release branch-0.20
Merge latest rapidsai/branch-0.20 into forked branch-0.20
aschaffer/21.08 <- rapidsai/21.08
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@61b99df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1875   +/-   ##
===============================================
  Coverage                ?   70.13%           
===============================================
  Files                   ?      143           
  Lines                   ?     8812           
  Branches                ?        0           
===============================================
  Hits                    ?     6180           
  Misses                  ?     2632           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b99df...a9abf93. Read the comment docs.

@aschaffer aschaffer changed the title node2vec Sampling Implementation [WIP] node2vec Sampling Implementation Oct 12, 2021
@aschaffer aschaffer requested a review from a team as a code owner October 14, 2021 20:54
@BradReesWork BradReesWork requested review from ChuckHastings and rlratzel and removed request for rlratzel October 15, 2021 17:17
@BradReesWork BradReesWork added the non-breaking Non-breaking change label Oct 20, 2021
@BradReesWork BradReesWork added this to the 21.12 milestone Oct 20, 2021
@BradReesWork BradReesWork added the DO NOT MERGE Hold off on merging; see PR for details label Oct 20, 2021
@aschaffer aschaffer changed the title [WIP] node2vec Sampling Implementation [REVIEW] node2vec Sampling Implementation Oct 25, 2021
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork BradReesWork removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 27, 2021
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for few minor complaints.

@BradReesWork
Copy link
Member

rerun tests

@aschaffer
Copy link
Collaborator Author

rerun tests

1 similar comment
@rlratzel
Copy link
Contributor

rerun tests

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 731065f into rapidsai:branch-21.12 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants