Fixing Nx and Graph/DiGraph issues#1882
Merged
rapids-bot[bot] merged 13 commits intorapidsai:branch-21.12from Nov 1, 2021
BradReesWork:branch-21.12-bug
Merged
Fixing Nx and Graph/DiGraph issues#1882rapids-bot[bot] merged 13 commits intorapidsai:branch-21.12from BradReesWork:branch-21.12-bug
rapids-bot[bot] merged 13 commits intorapidsai:branch-21.12from
BradReesWork:branch-21.12-bug
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1882 +/- ##
================================================
+ Coverage 70.11% 70.30% +0.18%
================================================
Files 143 143
Lines 8827 8863 +36
================================================
+ Hits 6189 6231 +42
+ Misses 2638 2632 -6
Continue to review full report at Codecov.
|
rlratzel
reviewed
Oct 26, 2021
Contributor
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, just had some suggestions below.
jnke2016
reviewed
Oct 26, 2021
jnke2016
reviewed
Oct 26, 2021
jnke2016
reviewed
Oct 26, 2021
jnke2016
reviewed
Oct 26, 2021
jnke2016
reviewed
Oct 26, 2021
jnke2016
reviewed
Oct 26, 2021
Contributor
jnke2016
left a comment
There was a problem hiding this comment.
Overall looks good to me. just few comments
rlratzel
approved these changes
Oct 28, 2021
jnke2016
approved these changes
Oct 29, 2021
Member
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a number of issues with conversion of Nx directed graphs. Fix nx tests, fixed issues with using new Graph(directed=true) but checking for DiGraph