Skip to content

Add raft ops for reduce_v and transform_reduce_v#1902

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.12from
kaatish:reduce-prims-ops
Oct 27, 2021
Merged

Add raft ops for reduce_v and transform_reduce_v#1902
rapids-bot[bot] merged 2 commits intorapidsai:branch-21.12from
kaatish:reduce-prims-ops

Conversation

@kaatish
Copy link
Collaborator

@kaatish kaatish commented Oct 24, 2021

reduce_v and transform_reduce_v support raft::comms::op_t as a parameter. Tests have been updated accordingly.
Fixes #1903

@kaatish kaatish requested a review from a team as a code owner October 24, 2021 05:08
@kaatish kaatish self-assigned this Oct 24, 2021
@kaatish kaatish added this to the 21.12 milestone Oct 24, 2021
@kaatish kaatish added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2021
@kaatish kaatish requested a review from seunghwak October 24, 2021 05:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@61b99df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1902   +/-   ##
===============================================
  Coverage                ?   70.13%           
===============================================
  Files                   ?      143           
  Lines                   ?     8812           
  Branches                ?        0           
===============================================
  Hits                    ?     6180           
  Misses                  ?     2632           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b99df...5cc7522. Read the comment docs.

@kaatish kaatish requested a review from ChuckHastings October 25, 2021 14:01
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

We may consider dropping PROD support at this moment.

@ChuckHastings
Copy link
Collaborator

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2f3ed7a into rapidsai:branch-21.12 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Add support for raft comms operators in reduce_v and transform_reduce_v

5 participants