Skip to content

Disable HITS and setup 11.5 env#1930

Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-21.12from
BradReesWork:branch-21.12-11.5
Nov 8, 2021
Merged

Disable HITS and setup 11.5 env#1930
rapids-bot[bot] merged 12 commits intorapidsai:branch-21.12from
BradReesWork:branch-21.12-11.5

Conversation

@BradReesWork
Copy link
Member

Temporarily disable HITS (PR 1898 will turn it back on)

@BradReesWork BradReesWork requested review from a team as code owners November 5, 2021 17:15
@BradReesWork BradReesWork added breaking Breaking change improvement Improvement / enhancement to an existing function labels Nov 5, 2021
@BradReesWork BradReesWork added this to the 21.12 milestone Nov 5, 2021
@BradReesWork BradReesWork requested a review from a team as a code owner November 5, 2021 17:41
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BradReesWork BradReesWork requested a review from a team as a code owner November 5, 2021 17:48
@BradReesWork BradReesWork changed the title [WIP] Disable HITS and setup 11.5 env Disable HITS and setup 11.5 env Nov 5, 2021
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@61e8bad). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 293486a differs from pull request most recent head 7dd5f05. Consider uploading reports for the commit 7dd5f05 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1930   +/-   ##
===============================================
  Coverage                ?   70.04%           
===============================================
  Files                   ?      143           
  Lines                   ?     8904           
  Branches                ?        0           
===============================================
  Hits                    ?     6237           
  Misses                  ?     2667           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e8bad...7dd5f05. Read the comment docs.

@BradReesWork
Copy link
Member Author

@gpucibot merge

1 similar comment
@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 61950dd into rapidsai:branch-21.12 Nov 8, 2021
rapids-bot bot pushed a commit that referenced this pull request Nov 11, 2021
…entation (#1941)

Followup PR to #1930

This PR re-enables HITS in the python API using the new C++ primitive-based implementation. This also refactors the tests to use the benchmark fixture plugin, and adds an additional dataset to read for more diverse comparison to Nx.

![image](https://user-images.githubusercontent.com/3039903/141236018-16557063-9d2a-4fd7-b8c1-789f78958ea7.png)

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Brad Rees (https://github.com/BradReesWork)
  - Joseph Nke (https://github.com/jnke2016)

URL: #1941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change improvement Improvement / enhancement to an existing function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants