Use collections.abc.Sequence instead of deprecated collections.Sequence.#1932
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-21.12from Nov 7, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1932 +/- ##
===============================================
Coverage ? 70.42%
===============================================
Files ? 143
Lines ? 8913
Branches ? 0
===============================================
Hits ? 6277
Misses ? 2636
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi cuGraph team! I was looking at a couple things across RAPIDS related to Python 3.10 compatibility. There is one spot where the deprecated name
collections.Sequenceis used. This was moved tocollections.abc.Sequencein Python 3.3 and has been deprecated for a while. In Python 3.10 the deprecated names for abstract base classes likecollections.Sequencewere removed.This PR fixes that module path to help with eventual compatibility with Python 3.10+. I think this is the only instance of this deprecated name across RAPIDS packages.
(I don't have permissions to set labels or project boards, so the label checker will fail until someone else does that.)