Accounting for raft::random detail changes#1937
Accounting for raft::random detail changes#1937rapids-bot[bot] merged 5 commits intorapidsai:branch-21.12from
Conversation
rlratzel
left a comment
There was a problem hiding this comment.
just confirmed with @divyegala that the fork and version updates to get_raft.cmake are temporary, and will be reverted after rapidsai/raft#356 is merged.
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1937 +/- ##
===============================================
Coverage ? 70.35%
===============================================
Files ? 143
Lines ? 8903
Branches ? 0
===============================================
Hits ? 6264
Misses ? 2639
Partials ? 0 Continue to review full report at Codecov.
|
|
rerun tests |
cpp/src/detail/shuffle_wrappers.cu
Outdated
| #include <cugraph/utilities/shuffle_comm.cuh> | ||
|
|
||
| #include <raft/random/rng.cuh> | ||
| #include <raft/random/rng.hpp> |
There was a problem hiding this comment.
This one can be deleted, this file does not use raft's random number generator.
seunghwak
left a comment
There was a problem hiding this comment.
Looks good for me except for the unnecessary include statement in shuffle_wrappers.cu.
|
rerun tests CPU build had: and retry failed, so I wonder if the uploaded package is corrupted? edit: CI checks all passed after this rerun, so the package is likely okay. |
|
@gpucibot merge |
Depends on rapidsai/raft#356