Propose extract_bfs_paths C API#1955
Conversation
ChuckHastings
added
3 - Ready for Review
feature request
|
rerun tests |
1 similar comment
|
rerun tests |
|
rerun tests Rerunning to get latest updates that should fix build problem. |
|
I talked with @ChuckHastings offline, and something we discussed is that these new APIs could be used for general path extraction - not just for extracting paths from BFS results - and should be renamed without |
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Just added a reminder for a FIXME we discussed.
Also, this PR could add a unit test too, which calls a stubbed out implementation. I personally would benefit from seeing how the API is meant to be used in the context of an actual BFS call.
|
rerun tests CI failed due to what looks like a problem Jenkins had in accessing github. Rerunning in case this was temporary. |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #1955 +/- ##
===============================================
Coverage ? 70.28%
===============================================
Files ? 143
Lines ? 8922
Branches ? 0
===============================================
Hits ? 6271
Misses ? 2651
Partials ? 0 Continue to review full report at Codecov.
|
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Thanks, LGTM. I had some small suggestions which need not hold up my approval.
…at will force building of the python package in the cpu build script.
…nterpreted as a URL, saving the work dir for the python builds too.
|
rerun tests |
…tall pylibcugraph from the Proj Flash tarfile.
… a cudf bug and not the way CI was building packages. Also updated cuda11.5 conda dev env file for 22.02 packages.
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
Looks good to me, I have just a minor comment to think about.
| * from a seed. | ||
| */ | ||
| typedef struct { | ||
| int align_; |
There was a problem hiding this comment.
Should we better use int32_t instead of int if the intention here is to really enforce 4 byte alignment?
There was a problem hiding this comment.
Good point. Will fix in the implementation PR.
|
@gpucibot merge |
6 participants
This PR defines the C API for extract_bfs_paths. Implementation will follow once the API is approved.
Partially addresses #1891