Removal of remaining DiGraph Python mentions#2049
Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-22.04from Feb 4, 2022
Merged
Removal of remaining DiGraph Python mentions#2049rapids-bot[bot] merged 11 commits intorapidsai:branch-22.04from
rapids-bot[bot] merged 11 commits intorapidsai:branch-22.04from
Conversation
rlratzel
requested changes
Jan 31, 2022
Contributor
rlratzel
left a comment
There was a problem hiding this comment.
Overall it looks good so far, and here's some early feedback. The main goal is that the cugraph code should not be using deprecated code, and this PR accomplishes that, but we may want to roll back a few of these other changes to allow users to continue to use the deprecated classes in case they haven't migrated yet, but we can discuss offline..
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2049 +/- ##
================================================
- Coverage 73.26% 73.11% -0.16%
================================================
Files 151 155 +4
Lines 9736 10061 +325
================================================
+ Hits 7133 7356 +223
- Misses 2603 2705 +102
Continue to review full report at Codecov.
|
rlratzel
requested changes
Feb 2, 2022
rlratzel
approved these changes
Feb 4, 2022
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2005 when merged