Updates to enable NumberMap to generate unique src/dst column names#2050
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.04from Jan 31, 2022
Conversation
…red src and dst columns, updated all code using it to access the generated names from the NumberMap instance instead of hardcoding "src" and "dst". This was needed since cudf no longer allows for duplicate column names, and some user input may contain "src" and "dst" as pre-existing column names. This commit also clean up various tech debt (exception types, docstrings, etc.).
rlratzel
added
bug
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2050 +/- ##
===============================================
Coverage ? 73.08%
===============================================
Files ? 151
Lines ? 9827
Branches ? 0
===============================================
Hits ? 7182
Misses ? 2645
Partials ? 0 Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Jan 31, 2022
ChuckHastings
approved these changes
Jan 31, 2022
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberMapto generate unique src/dst column names instead of assuming the namessrcanddst. This is needed since cudf no longer allows for duplicate column names, and some user input may contain "src" and "dst" as pre-existing column names intended for other purposes.Tested by ensuring the existing python unit tests for SG and MG (2 GPUs) passed, and also ran all notebooks as tests. New tests to emphasize support for specific column names that previously failed with the latest cudf were also added.