Define the uniform neighbor sampling C API#2112
Conversation
ChuckHastings
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2112 +/- ##
===============================================
Coverage ? 73.99%
===============================================
Files ? 157
Lines ? 10496
Branches ? 0
===============================================
Hits ? 7767
Misses ? 2729
Partials ? 0 Continue to review full report at Codecov.
|
| ::cugraph_type_erased_device_array_view_t const* start, | ||
| ::cugraph_type_erased_device_array_view_t const* start_label, | ||
| ::cugraph_type_erased_host_array_view_t const* fan_out, | ||
| bool without_replacement) |
There was a problem hiding this comment.
The C++ API defines the semantic of this flag as with_replacement (which defaults to true). I know this code is ifdef-out for now, but it's meant to be brought back, as far as I understand.
There was a problem hiding this comment.
Yes. I defined this based on the old definition in the C++ API. Fixed in latest push.
| const cugraph_type_erased_device_array_view_t* start, | ||
| const cugraph_type_erased_device_array_view_t* start_label, | ||
| const cugraph_type_erased_host_array_view_t* fan_out, | ||
| bool_t without_replacement, |
There was a problem hiding this comment.
No do_expensive_check here (at least as a placeholder even if we're not checking anything at this moment)?
There was a problem hiding this comment.
Added in latest push.
|
rerun tests |
|
@gpucibot merge |
5 participants
Define the uniform neighborhood sampling C API. The implementation will be done in a separate PR. An outline of what the implementation will resemble is provided (but ifdef'ed out).