HITS C API implementation#2150
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
cpp/src/detail/shuffle_wrappers.cu
Outdated
| d_vertices.begin(), | ||
| d_vertices.end(), | ||
| d_values.begin(), | ||
| [key_func = cugraph::detail::compute_gpu_id_from_vertex_t<vertex_t>{comm_size}] __device__( |
There was a problem hiding this comment.
Have you tested with initial guess hub values? If I am not mistaken, you're calling this after renumbering, but cugrpah::detail::compute_gpu_id_from_vertex_t expects original (before renumbering) vertex IDs.
There was a problem hiding this comment.
adding a test in the next push. Refactored this code as you suggested.
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2150 +/- ##
================================================
+ Coverage 73.95% 73.99% +0.04%
================================================
Files 157 157
Lines 10496 10496
================================================
+ Hits 7762 7767 +5
+ Misses 2734 2729 -5
Continue to review full report at Codecov.
|
| vertex_t local_vertex_first, | ||
| vertex_t local_vertex_last, | ||
| value_t default_value, | ||
| bool do_expensive_check); |
There was a problem hiding this comment.
Do we still need this function?
There was a problem hiding this comment.
We are using this function, I think it addresses what you are suggesting needs to be done.
collect_renumber_ext_vertex_values_to_local does:
- shuffle to get ext vertex values to the proper GPU
- local renumber of ext vertices
- scatter to populate our dense vertex property arrays
If I can rename the function to make it more clear that these steps are what is done, I'm open to a better name.
There was a problem hiding this comment.
Gotcha, so this function gets actually updated to implement the new logic.
There was a problem hiding this comment.
Maybe something like collect_local_vertex_values_from_ext_vertex_value_pairs... ?
There was a problem hiding this comment.
Sounds good. I'll update the function name.
|
@gpucibot merge |
4 participants
Closes #2092
Provide the C API implementation for HITS. Adds a unit tester for MG, updates the unit tests for both SG and MG.