add bindings for triangle counting#2273
add bindings for triangle counting#2273rapids-bot[bot] merged 19 commits intorapidsai:branch-22.06from
Conversation
|
rerun tests |
…6-fea_add_triangle_counting_bindings
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2273 +/- ##
================================================
- Coverage 63.55% 63.09% -0.46%
================================================
Files 102 104 +2
Lines 4547 4653 +106
================================================
+ Hits 2890 2936 +46
- Misses 1657 1717 +60
Continue to review full report at Codecov.
|
rlratzel
left a comment
There was a problem hiding this comment.
Looks pretty good, just a few requests.
rlratzel
left a comment
There was a problem hiding this comment.
Also, we should probably have some minimal test coverage in pylibcugraph for triangle count - I didn't see a new test in pylibcugraph.
| from pylibcugraph.katz_centrality import EXPERIMENTAL__katz_centrality | ||
| katz_centrality = experimental_warning_wrapper(EXPERIMENTAL__katz_centrality) | ||
|
|
||
| from pylibcugraph.triangle_count import triangle_count |
There was a problem hiding this comment.
Triangle count is a new pylibcugraph binding, so it wouldn't have been in experimental for a release. Is the promoted from experimental warning necessary in that case / having it also in experimental?
…6-fea_add_triangle_counting_bindings
…dd a deprecation warning to the current one
…6-fea_add_triangle_counting_bindings
|
@gpucibot merge |
This PR add python bindings for triangle counting.
cuGraphandpylibcuGraphtests completedFails when sampling some vertices from the graph that will be used as parameter (
start_list) for the MG implementationThe SG implementation works with and without
start_list