Add and test mechanism for creating graph with edge index as weight#2288
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.06from May 23, 2022
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
seunghwak
approved these changes
May 19, 2022
cpp/tests/c_api/mg_test_utils.cpp
Outdated
|
|
||
| return test_ret_value; | ||
| } | ||
| extern "C" int create_mg_test_graph_with_ids(const cugraph_resource_handle_t* handle, |
Contributor
There was a problem hiding this comment.
with_edge_ids might be more intuitive?
Collaborator
Author
There was a problem hiding this comment.
Fixed in latest push
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2288 +/- ##
================================================
- Coverage 63.82% 63.69% -0.14%
================================================
Files 100 100
Lines 4484 4481 -3
================================================
- Hits 2862 2854 -8
- Misses 1622 1627 +5
Continue to review full report at Codecov.
|
jnke2016
approved these changes
May 20, 2022
Contributor
jnke2016
left a comment
jnke2016
left a comment
There was a problem hiding this comment.
Reviewed and tested. It looks good to me
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this in the last uniform neighborhood sampling updates.
Added a mechanism for creating a graph using an edge index as the weight. This is a temporary mechanism until we add direct support for edge indexes in the graph.