Skip to content

Remove legacy katz#2324

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-22.08from
ChuckHastings:remove_legacy_katz
Jun 6, 2022
Merged

Remove legacy katz#2324
rapids-bot[bot] merged 5 commits intorapidsai:branch-22.08from
ChuckHastings:remove_legacy_katz

Conversation

@ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jun 1, 2022 •
edited
Loading

Remove the legacy Katz implementation which is no longer used.

Marked as breaking since it deletes a C++ API.

@ChuckHastings ChuckHastings requested review from a team as code owners June 1, 2022 23:02
@review-notebook-app
Copy link

review-notebook-app bot commented Jun 1, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ChuckHastings ChuckHastings self-assigned this Jun 1, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function breaking Breaking change labels Jun 1, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 1, 2022
@ChuckHastings ChuckHastings changed the base branch from branch-21.08 to branch-22.08 June 1, 2022 23:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@5ae30cc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 11b277d differs from pull request most recent head b8d5d69. Consider uploading reports for the commit b8d5d69 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08    #2324   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae30cc...b8d5d69. Read the comment docs.

seunghwak
seunghwak approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the C++ part.

seunghwak
seunghwak reviewed Jun 2, 2022
View reviewed changes
conda/environments/cugraph_dev_cuda11.5.yml Outdated
- gmock=1.10.0
- ptxcompiler # [linux64]
- gcc_linux-64=9.* # [linux64]
- sysroot_linux-64==2.17 # [linux64]
Copy link
Contributor

@seunghwak seunghwak Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update for other conda files (for different CUDA versions)?

Copy link
Collaborator Author

@ChuckHastings ChuckHastings Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I actually accidentally included this in the PR, this update (along with the other files) should probably be in a separate PR. Let me see if I can do that.

Copy link
Collaborator Author

@ChuckHastings ChuckHastings Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this change into a separate PR that addresses all of the CUDA versions.

@ajschmidt8 ajschmidt8 removed the request for review from a team June 3, 2022 14:11
@ChuckHastings
Copy link
Collaborator Author

ChuckHastings commented Jun 6, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d9d3230 into rapidsai:branch-22.08 Jun 6, 2022
@ChuckHastings ChuckHastings deleted the remove_legacy_katz branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seunghwak seunghwak seunghwak approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels

breaking Breaking change improvement Improvement / enhancement to an existing function

Projects

None yet

Milestone

22.08

Development

Successfully merging this pull request may close these issues.

4 participants

@ChuckHastings @codecov-commenter @rlratzel @seunghwak