Fix triangle count#2325
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.08from Jun 16, 2022
Merged
Conversation
ChuckHastings
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2325 +/- ##
===============================================
Coverage ? 61.45%
===============================================
Files ? 107
Lines ? 5759
Branches ? 0
===============================================
Hits ? 3539
Misses ? 2220
Partials ? 0 Continue to review full report at Codecov.
|
Collaborator
Author
|
rerun tests |
seunghwak
approved these changes
Jun 7, 2022
| cugraph_type_erased_device_array_view_t* p_start_view = NULL; | ||
|
|
||
| int rank = 0; | ||
| rank = cugraph_resource_handle_get_rank(handle); |
Contributor
There was a problem hiding this comment.
Sorry for nitpicking, but int rank = cugraph_resource_handle_get_rank(handle); might be cleaner.
Collaborator
Author
|
rerun tests |
5 similar comments
Collaborator
Author
|
rerun tests |
Collaborator
Author
|
rerun tests |
Collaborator
Author
|
rerun tests |
Collaborator
Author
|
rerun tests |
Collaborator
Author
|
rerun tests |
Collaborator
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed MG issue discovered by @jnke2016.
Triangle count test was not correct for MG. If vertices are specified, the output size isn't known until after vertices are shuffled to the correct GPU.